Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dji/tello: fix the issue about Halt method #858

Merged
merged 4 commits into from
Sep 26, 2022
Merged

dji/tello: fix the issue about Halt method #858

merged 4 commits into from
Sep 26, 2022

Commits on May 25, 2021

  1. Dji Tello Halt does not terminate all the related goroutines and may … 

    …wait forever when it is called multiple times

Add failing unit tests.
    @st-user
    st-user committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1ffc138 View commit details
    Browse the repository at this point in the history

  2. Dji Tello Halt does not terminate all the related goroutines and may … 

    …wait forever when it is called multiple times

Fix the issue.
    @st-user
    st-user committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8c5ac6f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. Dji Tello Halt does not terminate all the related goroutines and may … 

    …wait forever when it is called multiple times

Fix the test for Halt method so that it waits for all the related goroutines to complete.
    @st-user
    st-user committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    7840b83 View commit details
    Browse the repository at this point in the history

  2. Dji Tello Halt does not terminate all the related goroutines and may … 

    …wait forever when it is called multiple times

Halt method waits forever when at least one of the goroutines is blocked by its Read method. To avoid this, I make Halt method close the connections before writing to doneCh.
    @st-user
    st-user committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    46725e9 View commit details
    Browse the repository at this point in the history