fix: eslint import/no-unresolved error #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripecosta
commented
Aug 14, 2024
| @@ -13,6 +13,7 @@ | |||
| "browser": true, | |||
| "node": true | |||
| }, | |||
| "reportUnusedDisableDirectives": true, | |||
There was a problem hiding this comment.
This will help spot if the import/no-unresolved gets fixed.
ripecosta
commented
Aug 14, 2024
| @@ -369,7 +369,7 @@ export function Trans({ | |||
| ) | |||
| return; | |||
|
|
|||
| // eslint-disable-next-line react/no-unstable-nested-components, no-inner-declarations | |||
| // eslint-disable-next-line react/no-unstable-nested-components | |||
There was a problem hiding this comment.
Found after enabling reportUnusedDisableDirectives.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address the ESLint error introduced in #1790. I was unable to understand why it was happening so I opted to add an ignore to it to unblock master.
Checklist
npm run test