Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwi tree #847

Merged
merged 24 commits into from
Jan 29, 2025
Merged

Kiwi tree #847

merged 24 commits into from
Jan 29, 2025

Conversation

MartynasStrazdas
Copy link
Contributor

@MartynasStrazdas MartynasStrazdas commented Jan 21, 2025

Early preview of how the kiwi tree looks.

There are plenty of things that are not yet released from kiwi side, that we want:

  1. Separate error nodes: will be provided eventually
  2. Action items wrapper: so far can't provide use case or check if we need it as actions don't seem to work as intended with icons.
  3. Multiline label: for now only label is available, sublabel should be added by kiwi.
  4. Size for tree items: size is removed, component has property density to control size of all components.
  5. ...

Tree renderer property name changes so far:
IsSelected => selected
isDisabled => aria-disabled (need to figure out if we want a separate prop)

General:

  1. Icons are now provided through Href, but it seems all tree will continue to support basic svg (actions/node icons).
  2. There is no to little changes for using new TreeRenderer.

Tree preview:

tree-preview.mp4

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: f5385f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartynasStrazdas MartynasStrazdas changed the base branch from master to next January 28, 2025 09:31
@MartynasStrazdas MartynasStrazdas marked this pull request as ready for review January 28, 2025 09:37
@MartynasStrazdas MartynasStrazdas requested a review from a team as a code owner January 28, 2025 09:37
Copy link
Member

@saskliutas saskliutas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for an initial attempt. Should be enough to integrate into tree-widget.

@MartynasStrazdas MartynasStrazdas merged commit 00e2d53 into next Jan 29, 2025
6 checks passed
@MartynasStrazdas MartynasStrazdas deleted the mast/kiwi-tree branch January 29, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hierarchies-react: Update tree and tree node renderers to use iTwinUI v5
3 participants