Move [cz]symv and [cz]syr from LAPACK++ #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weslleyspereira Related to earlier discussion in PR #11. |
…are defined in LAPACK, not in reference BLAS, so require a full LAPACK.
`string( REGEX MATCH pattern x str )` as simpler and more robust than `if (pattern MATCHES str) set( x true ) endif` To be robust when x is already defined, that would need `else set( x false )`.
mgates3
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
mgates3
commented
Nov 6, 2024
test/test_symv.cc
Outdated
There was a problem hiding this comment.
Add to test.hh and test.cc.
Add to run_tests.py.
Compare with icl-utk-edu/lapackpp#71.
TeachRaccooon
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
[cz]symvand[cz]syrinto BLAS++, where they logically should reside, rather than LAPACK++, where they have resided for historical reasons.[cz]symvand[cz]syrare in LAPACK rather than Reference BLAS. Most vendors ship BLAS and LAPACK together (OpenBLAS, Intel MKL, Cray LibSci), so users don't notice the difference.However, IBM ESSL notably has only a limited subset of LAPACK, and lacks
[cz]symvand[cz]syr. For ESSL, users can also link with reference LAPACK to complete it. See https://www.ibm.com/docs/en/essl/6.3?topic=reference-lapack-lapacke.This supersedes PR #86.