Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move [cz]symv and [cz]syr to BLAS++ #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Nov 6, 2024

See icl-utk-edu/blaspp#91

Also resolves a conflict between the LAPACKE header and LAPACK++ header. They both typedef ... lapack_float_return, and didn't #define it to be able to guard. Other types like lapack_int were #define and guarded. This renames it to lapackpp_float_return. (This is really my fault for creating nearly identical config files in LAPACK and LAPACK++ and not guarding them properly. I was going with the "typedef is better" mantra, but the preprocessor doesn't know anything about typedefs. I'm not sure how this conflict never cropped up before.)

Also simplify the config.h header a bit — LAPACK++ doesn't need everything that LAPACK has.

Copy link
Collaborator Author

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

test/lapacke_wrappers.hh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants