Add nonuniform tile sizes, device distributions, and grid orders to even more testers (depends on #143) #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-lindquist
force-pushed
the
nonuniform-tests-2
branch
from
4e12da3
to
a6ea276
Compare
|
Yes, the draft status was just waiting for #143. |
mgates3
force-pushed
the
nonuniform-tests-2
branch
from
a6ea276
to
3bc5090
Compare
|
I rebased this on top of the current master with the merged-in #143. There were some merge conflicts, which hopefully I managed correctly. (I did them twice and compared to make sure.) |
mgates3
reviewed
Jan 23, 2024
mgates3
reviewed
Jan 31, 2024
mgates3
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work of #143 to add support for nonuniform tile sizes, device distributions, and grid orders to more testers. I also made a couple of related warning messages more consistent. However, I didn't change the defaults of
run-tests.pyto test the added configurations.The change is largely realized by refactoring the matrix creation logic into a helper function. This helps reduce the amount of duplicate code, which actually reduces the line count and the executable size a little bit.
Other improvements
henormandsynormwhen tiles are nonuniformtest/scalapack_support_routines.hhsince it's no longer useddev-distparam was flipped to matchslate/func.hhThis PR ended up longer than intended. I'd probably suggest starting with
test/test_util.hh,test/matrix_util.hh, andtest/matrix_util.cc. Also, the norm testers have some big indent changes, so I'd suggest reviewing that diff with "ignore whitespace" enabled.Diff w/ #143