Add nonuniform tile sizes to more testers & fix some related issues #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-lindquist
force-pushed
the
nonuniform-tests
branch
from
9aecfd2
to
99d3af6
Compare
neil-lindquist
changed the title
neil-lindquist
force-pushed
the
nonuniform-tests
branch
2 times, most recently
from
9aecfd2
to
8419365
Compare
neil-lindquist
force-pushed
the
nonuniform-tests
branch
from
8419365
to
bde9664
Compare
mgates3
requested changes
Jan 11, 2024
This seemed to be causing some issues for getrf w/ nonuniform tiles
mgates3
force-pushed
the
nonuniform-tests
branch
from
bde9664
to
69b44e9
Compare
mgates3
force-pushed
the
nonuniform-tests
branch
from
69b44e9
to
b4b88f8
Compare
mgates3
added a commit
that referenced
this pull request
Feb 4, 2024
Add nonuniform tile sizes, device distributions, and grid orders to even more testers (depends on #143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for nonuniform tile sizes to several of the testers (
gemm,gesv, the aux routines). While I was at it, I started refactoring some of the shared tester logic in the shared functions. I also addressed some other issues that I ran intoRemoved tile life fromMoved to Remove tile life from remaining routines #150getrf,getrf_tntpiv, andgetrf_nopivgetrfandgetrf_tntpivBaseMatrix::tileGettileLayoutConvertalways has sufficient workspaceMatrixStoragea little more robust against simultaneous operations.A few limitations:
getrf_tntpivcan be tested with nonuniform tile sizes, but has non-trivial assumptions about tile sizes.It's straightforward to add this to other testers, but I stopped here to make the code review easier.