Skip to content

review changes

review changes #187

Triggered via push November 11, 2024 13:57
Status Failure
Total duration 11m 14s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 4 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Rustfmt
Process completed with exit code 1.
Code coverage
Process completed with exit code 1.
`to_string` applied to a type that implements `Display` in `format!` args: zaino-fetch/src/jsonrpc/error.rs#L39
error: `to_string` applied to a type that implements `Display` in `format!` args --> zaino-fetch/src/jsonrpc/error.rs:39:80 | 39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `-D clippy::to-string-in-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`
`to_string` applied to a type that implements `Display` in `format!` args: zaino-fetch/src/jsonrpc/error.rs#L39
error: `to_string` applied to a type that implements `Display` in `format!` args --> zaino-fetch/src/jsonrpc/error.rs:39:80 | 39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `-D clippy::to-string-in-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`
useless conversion to the same type: `chain::error::BlockCacheError`: zaino-fetch/src/chain/block.rs#L478
error: useless conversion to the same type: `chain::error::BlockCacheError` --> zaino-fetch/src/chain/block.rs:478:23 | 478 | Err(e) => Err(e.into()), | ^^^^^^^^ help: consider removing `.into()`: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
useless conversion to the same type: `chain::error::BlockCacheError`: zaino-fetch/src/chain/block.rs#L478
error: useless conversion to the same type: `chain::error::BlockCacheError` --> zaino-fetch/src/chain/block.rs:478:23 | 478 | Err(e) => Err(e.into()), | ^^^^^^^^ help: consider removing `.into()`: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
Clippy (MSRV)
Clippy had exited with the 101 exit code
Test on macOS-latest
Process completed with exit code 101.
Test on windows-latest
The job was canceled because "macOS-latest" failed.
Test on windows-latest
The operation was canceled.
Test on ubuntu-latest
The job was canceled because "macOS-latest" failed.
Test on ubuntu-latest
The operation was canceled.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (MSRV)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/