Skip to content

review changes

review changes #187

GitHub Actions / Clippy (MSRV) failed Nov 11, 2024 in 0s

Clippy (MSRV)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check failure on line 39 in zaino-fetch/src/jsonrpc/error.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
  --> zaino-fetch/src/jsonrpc/error.rs:39:80
   |
39 |         tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string()))
   |                                                                                ^^^^^^^^^^^^ help: remove this
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
   = note: `-D clippy::to-string-in-format-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`

Check failure on line 39 in zaino-fetch/src/jsonrpc/error.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

`to_string` applied to a type that implements `Display` in `format!` args

error: `to_string` applied to a type that implements `Display` in `format!` args
  --> zaino-fetch/src/jsonrpc/error.rs:39:80
   |
39 |         tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string()))
   |                                                                                ^^^^^^^^^^^^ help: remove this
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
   = note: `-D clippy::to-string-in-format-args` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`

Check failure on line 478 in zaino-fetch/src/chain/block.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `chain::error::BlockCacheError`

error: useless conversion to the same type: `chain::error::BlockCacheError`
   --> zaino-fetch/src/chain/block.rs:478:23
    |
478 |         Err(e) => Err(e.into()),
    |                       ^^^^^^^^ help: consider removing `.into()`: `e`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

Check failure on line 478 in zaino-fetch/src/chain/block.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `chain::error::BlockCacheError`

error: useless conversion to the same type: `chain::error::BlockCacheError`
   --> zaino-fetch/src/chain/block.rs:478:23
    |
478 |         Err(e) => Err(e.into()),
    |                       ^^^^^^^^ help: consider removing `.into()`: `e`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`