fix-arm64 pdm4ar2024 #123
Open
fix-arm64 pdm4ar2024 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 78.31% 80.05% +1.74%
==========================================
Files 72 77 +5
Lines 4943 5386 +443
Branches 331 397 +66
==========================================
+ Hits 3871 4312 +441
+ Misses 991 970 -21
- Partials 81 104 +23 ☔ View full report in Codecov by Sentry. |
* add eval functions * add idm agent * rename the files * add unit test for safety eval * add unit test for efficiency metric * minor * minor * add unit test for comfort evaluation * minor * idm unit test with minor fix * add idm agent * idm unit test with minor fix * minor * minor * returns collided players * minors + fix for python3.9 * improve test coverage * use f-string * bugfix * add eval functions (#124) Add common functions to evaluate the performance of ego vehicle in the simulation. For safety, the functions to find the minimum distance, minimum time-to-collision(ttc) and maximum deceleration-rate-to-avoid-collision(drac) are implemented. The vehicle geometry is considered in the computation. For efficiency, the function to find the first time that the ego vehicle entered its desired lane is implemented. It only checks whether the vehicle enters the goal lane(or its predecessor/successor), regardless of the progress on the lane. For comfort, the max jerk and the rms of frequency-weighted acceleration(according to ISO2631) is computed. This will be merged after tested locally for the pdm4ar exercise. --------- Co-authored-by: alezana <[email protected]> * revert change in eval * revert change in eval --------- Co-authored-by: alezana <[email protected]>
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| from .vehicle_projected import VehicleStatePrj | ||
|
|
||
|
|
||
| @dataclass |
There was a problem hiding this comment.
Suggested change
| @dataclass | |
| @dataclass(frozen=True) |
Use frozen=True to make the dataclasses immutable and hashable. Read more.
| from dg_commons.sim.models.vehicle_dynamic import VehicleStateDyn | ||
|
|
||
|
|
||
| @dataclass(unsafe_hash=True, eq=True, order=True) |
There was a problem hiding this comment.
Suggested change
| @dataclass(unsafe_hash=True, eq=True, order=True) | |
| @dataclass(unsafe_hash=True, eq=True, order=True, frozen=True) |
Use frozen=True to make the dataclasses immutable and hashable. Explained here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.