Make @inngest/test -> inngest a regular dependency
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jpwilliams
force-pushed
the
fix/peer-deps-jsr-test
branch
from
7079366 to
c1f0b3e
Compare
BrunoScheufler
approved these changes
Oct 22, 2024
djfarrelly
approved these changes
Oct 22, 2024
3 tasks
jpwilliams
added a commit
that referenced
this pull request
Oct 22, 2024
## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> Fixes the release process failing if a package is already published on npm; this should just continue as normal, as these may be released by humans or other actions. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~Added a [docs PR](https://github.com/inngest/website) that references this PR~ N/A CI fix - [ ] ~Added unit/integration tests~ N/A CI fix - [x] Added changesets if applicable ## Related - Clean-up following borked release in #725 - should ensure this doesn't happen again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken JSR publishing for
@inngest/test.JSR doesn't support peer dependencies, though a non-optional peer dependency is identical to a regular dependency in any modern package manager.
Moving
inngestto be a regular dependency of@inngest/testto resolve the JSR publishing issue.Checklist
Added a docs PR that references this PRN/A Bug fixAdded unit/integration testsN/A Release CI