Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration Test] Shiny Test failure #1248

Open
donyunardi opened this issue Nov 19, 2024 · 2 comments · May be fixed by #1251
Open

[Integration Test] Shiny Test failure #1248

donyunardi opened this issue Nov 19, 2024 · 2 comments · May be fixed by #1251
Assignees
Labels

Comments

@donyunardi
Copy link
Contributor

shinytest2 unit tests failed last night:
https://nest.pages.roche.com/-/automation/systems-integration-tests/-/jobs/68071245/artifacts/public/logs/check-teal.modules.clinical.html

Here's couple first ones:

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-shinytest2-tm_a_mmrm.R:153:3'): e2e - tm_a_mmrm: Click on fit model shows table for default selection. ──
  all(unlist(col_val, use.names = FALSE) %in% colnames(table)) is not TRUE
  
  `actual`:   FALSE
  `expected`: TRUE 
  ── Failure ('test-shinytest2-tm_a_mmrm.R:154:3'): e2e - tm_a_mmrm: Click on fit model shows table for default selection. ──
  nrow(table) (`actual`) not equal to 25 (`expected`).
  
    `actual`:  0.0
  `expected`: 25.0
  ── Failure ('test-shinytest2-tm_a_mmrm.R:517:9'): e2e - tm_a_mmrm: Validate output on different selection on method t_mmrm_lsmeans. ──
  self$get_html(".shiny-output-error-validation") is not NULL
  
  `actual` is a character vector ('<div id="teal-teal_modules-mmrm-module-mmrm_table-table_out_main" class="shiny-html-output shiny-bound-output shiny-output-error shiny-output-error-shiny.silent.error shiny-output-error-validation recalculating" width="100%" aria-live="polite">Inputs changed and no longer reflect the fitted model. Press `Fit Model` button again to re-fit model.</div>')
  `expected` is NULL
  No validation error is observed
  Backtrace:
      ▆
   1. └─app_driver$expect_no_validation_error() at test-shinytest2-tm_a_mmrm.R:517:9
   2.   └─testthat::expect_null(...)
  ── Failure ('test-shinytest2-tm_g_forest_rsp.R:91:3'): e2e - tm_g_forest_rsp: Module initializes in teal without errors and produces plot output. ──
  self$get_html(".shiny-output-error:not(.shiny-output-error-validation)") is not NULL
  
  `actual` is a character vector ('<div class="shiny-html-output plot_out_container shiny-bound-output shiny-output-error" id="teal-teal_modules-forest_response-module-myplot-plot_out_main" width="100%" aria-live="polite">unable to find an inherited method for function ‘eval_code’ for signature ‘"teal_data", "list"’</div>')
  `expected` is NULL
  Shiny error is observed
  Backtrace:
      ▆
   1. └─app_driver$expect_no_shiny_error() at test-shinytest2-tm_g_forest_rsp.R:91:3
   2.   └─testthat::expect_null(...)
  ── Failure ('test-shinytest2-tm_g_forest_rsp.R:93:3'): e2e - tm_g_forest_rsp: Module initializes in teal without errors and produces plot output. ──
  app_driver$is_visible(app_driver$active_module_element("myplot-plot_main")) is not TRUE
  
  `actual` is NULL
  `expected` is a logical vector (TRUE)
  ── Failure ('test-shinytest2-tm_g_forest_rsp.R:163:3'): e2e - tm_g_forest_rsp: Selecting arm_var changes plot and doesn't throw validation errors. ──
  identical(plot_before, app_driver$get_active_module_plot_output("myplot")) is not FALSE
@shajoezhu
Copy link
Contributor

thanks a lot @donyunardi !

@m7pr
Copy link
Contributor

m7pr commented Nov 25, 2024

Hey, will have a look on this shortly

@m7pr m7pr linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants