Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update staged deps config #94

Merged
merged 5 commits into from
Aug 4, 2023
Merged

update staged deps config #94

merged 5 commits into from
Aug 4, 2023

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Aug 3, 2023

@pawelru pawelru mentioned this pull request Aug 3, 2023
Merged
Melkiades
Melkiades reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not to work atm. It is still not directing staged.deps towards the subdir

@pawelru
Copy link
Contributor Author

pawelru commented Aug 3, 2023

It seems not to work atm. It is still not directing staged.deps towards the subdir

Have you tested this locally? CI is using old version. I think I can temporarily replace it with my feature branch. Let me check.

pawelru
pawelru commented Aug 3, 2023
View reviewed changes
.github/workflows/check.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Unit Tests Summary

    1 files  2 suites   1m 13s ⏱️
  26 tests 0 ✔️   26 💤 0 ❌
274 runs  0 ✔️ 274 💤 0 ❌

Results for commit b9a3531.

@pawelru
Copy link
Contributor Author

pawelru commented Aug 3, 2023

got success using main version of staged.dependencies package ✅

Melkiades
Melkiades approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once reverted, it is good to go for me! Thanks Pawel ;)

pawelru
pawelru commented Aug 4, 2023
View reviewed changes
.github/workflows/check.yml Outdated Show resolved Hide resolved
@pawelru pawelru merged commit 32b7a97 into main Aug 4, 2023
10 checks passed
@pawelru pawelru deleted the support-subdir-v2 branch August 4, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelru @Melkiades