Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhanced subdir support for gitlab #182

Merged
merged 3 commits into from
Aug 3, 2023
Merged

enhanced subdir support for gitlab #182

merged 3 commits into from
Aug 3, 2023

Conversation

pawelru
Copy link
Collaborator

@pawelru pawelru commented Aug 3, 2023 •
edited
Loading

I followed your suggestion of a new (optional) field subdir in the staged deps config.

Follow-up PRs:

@pawelru pawelru requested a review from cicdguy August 3, 2023 10:01
@pawelru pawelru linked an issue Aug 3, 2023 that may be closed by this pull request
Subdirectory support results in error for GitLab projects #181
Closed
This was referenced Aug 3, 2023
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

Unit Tests Summary

    1 files    13 suites   7s ⏱️
  70 tests   70 ✔️ 0 💤 0 ❌
209 runs  209 ✔️ 0 💤 0 ❌

Results for commit a9683f9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------
R/caching.R                  174       6  96.55%   48, 76, 142-145
R/dependencies_app.R         131     131  0.00%    38-193
R/dependencies_helper.R      239      72  69.87%   42-43, 47, 52-55, 91-107, 113-122, 127-134, 140-143, 148-155, 161, 169-175, 231, 265, 277-295, 306, 415
R/dependencies.R             347      42  87.90%   87, 94, 112, 130, 214-230, 273, 281-284, 286, 299, 384, 449, 494-507, 552, 623-624, 631, 722
R/git_tools.R                183      87  52.46%   55, 73, 92-99, 102, 107, 124, 135-138, 155, 158-165, 181-205, 245-321
R/graph_methods.R             71       1  98.59%   116
R/host.R                      19      10  47.37%   5-8, 19-25
R/ref_strategy.R              44       0  100.00%
R/renv.R                      13       0  100.00%
R/rstudio_addins.R             5       5  0.00%    6-22
R/rstudio_jobs.R              27      27  0.00%    3-74
R/utils.R                    100       6  94.00%   2, 8, 73-74, 83, 93
R/zzz.R                       23      14  39.13%   31-45
TOTAL                       1376     401  70.86%

Results for commit: a418d0d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

cicdguy
cicdguy approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

R/git_tools.R
repo = strsplit(ref, "/")[[1]][2],
subdir = paste0(strsplit(ref, "/")[[1]][-(1:2)], collapse = "/")
)
file.path(host, paste0(repo, ".git"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so much cleaner 😌

@pawelru
Copy link
Collaborator Author

pawelru commented Aug 3, 2023

It's passing so I am going to merge it now. Can you please execute the release of this as well as use this version in the workflows? Once done I will re-run my PRs and merge them

@pawelru pawelru merged commit 5341308 into main Aug 3, 2023
18 checks passed
@pawelru pawelru deleted the support-subdir-v2 branch August 3, 2023 12:07
pawelru added a commit to insightsengineering/tern that referenced this pull request Aug 4, 2023
@pawelru @Melkiades
update staged deps config (#1022)
1492a45 
test with openpharma/staged.dependencies#182

Co-authored-by: Davide Garolini <[email protected]>
pawelru added a commit to insightsengineering/tlg-catalog that referenced this pull request Aug 4, 2023
@pawelru
update staged deps config (#94)
32b7a97 
test with openpharma/staged.dependencies#182

---------

Signed-off-by: Pawel Rucki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdguy cicdguy cicdguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subdirectory support results in error for GitLab projects
2 participants
@pawelru @cicdguy