Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configurable skills recipe #432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leseb
Copy link

@leseb leseb commented Dec 9, 2024

55e85c0 feat: allow configurable skills recipe

commit 55e85c0
Author: Sébastien Han [email protected]
Date: Mon Dec 9 10:58:54 2024 +0100

feat: allow configurable skills recipe

Introduced the ability to specify a custom skills recipe file via the
`skills_recipe_path` option. This enhancement enables users to
fine-tune data mixing processes by providing a tailored YAML recipe.
Practical use cases include adjusting sampling sizes or customizing
dataset definitions.

Co-authored-by: Michael Clifford <[email protected]>
Signed-off-by: Sébastien Han <[email protected]>

Introduced the ability to specify a custom skills recipe file via the
`skills_recipe_path` option. This enhancement enables users to
fine-tune data mixing processes by providing a tailored YAML recipe.
Practical use cases include adjusting sampling sizes or customizing
dataset definitions.

Co-authored-by: Michael Clifford <[email protected]>
Signed-off-by: Sébastien Han <[email protected]>
@mergify mergify bot added documentation Improvements or additions to documentation testing Relates to testing ci-failure labels Dec 9, 2024
@bbrowning
Copy link
Contributor

I'm not sure how much (if any) we want to expand the existing mixing and recipe work until we separate out mixing from data generation. Others on the team may have more opinions, but this may be something we want to hold off on for a bit until some larger needed refactorings happen.

@leseb
Copy link
Author

leseb commented Dec 10, 2024

@bbrowning Thanks for checking this out. Could you please share the relevant issues tracking the refactoring so we can stay updated? Much appreciated!

Copy link
Contributor

mergify bot commented Dec 10, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @leseb please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 10, 2024
@bbrowning
Copy link
Contributor

@leseb #412 is probably the best tracker for some of that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-failure documentation Improvements or additions to documentation needs-rebase testing Relates to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants