rust: use a different METHOD_LOAD event
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Rust bindings used the `iJVM_EVENT_TYPE_METHOD_INLINE_LOAD_FINISHED` event to notify VTune of new JIT code. This may not be correct: it is unclear from the documentation, but an "inline JIT-compiled method" sounds more like self-modifying code, not typically what we think of with JIT-compiled code. JIT-compiled as used elsewhere (e.g., Wasmtime) is emitted in a memory allocation that is separate from the runtime binary code region. This change uses the `iJVM_EVENT_TYPE_METHOD_LOAD_FINISHED` event instead.
ekovanova
approved these changes
Oct 23, 2023
|
Just tested this change with wasmtime, it fixes the Dynamic Code visibility issue. Tested with a simple Fibonacci fib.wasm file, and can see the following with vtune -
Checked collection logs of vtune, nothing suspicious there. Change looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Rust bindings used the
iJVM_EVENT_TYPE_METHOD_INLINE_LOAD_FINISHEDevent to notify VTune of new JIT code. This may not be correct: it is unclear from the documentation, but an "inline JIT-compiled method" sounds more like self-modifying code, not typically what we think of with JIT-compiled code. JIT-compiled code, as used elsewhere (e.g., Wasmtime), is typically emitted in a memory allocation that is separate from the runtime binary code region. This change uses theiJVM_EVENT_TYPE_METHOD_LOAD_FINISHEDevent instead.