feat(ui): add out of sync details to default settings button #7188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
maryhipp
changed the title
Using `&&` will result in false negatives for settings where a falsy value might be valid. For example, any setting for which 0 is a valid number. To be on the safe side, just use an explicit null check on all values.
A blue button is begging to be clicked, but clicking it will do nothing. Instead, we should communicate that no action is needed by disabling the button when the default settings are already in use.
psychedelicious
force-pushed
the
maryhipp/warn-out-of-sync-default-settings
branch
from
77f5e1e
to
eeb064b
Compare
psychedelicious
approved these changes
Oct 25, 2024
psychedelicious
deleted the
maryhipp/warn-out-of-sync-default-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a model does not have default settings, disable button with tooltip detailing where to find them.
If a model does have default settings and all generation settings are in sync, disable button with tooltip telling them that
If a model does have default settings and any generation settings are out of sync, make it orange with tooltip listing which settings are out of sync
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist