Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add out of sync details to default settings button #7188

Merged
merged 7 commits into from
Oct 25, 2024
Merged

feat(ui): add out of sync details to default settings button #7188

merged 7 commits into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. feat(ui): add out of sync details to model default settings button

    @psychedelicious
    Mary Hipp authored and psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    cc66132 View commit details
    Browse the repository at this point in the history

  2. tweak(ui): defaults sync tooltip styling

    @psychedelicious
    psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    71a3a3a View commit details
    Browse the repository at this point in the history

  3. fix(ui): use explicit null check when comparing default settings 

    Using `&&` will result in false negatives for settings where a falsy value might be valid. For example, any setting for which 0 is a valid number. To be on the safe side, just use an explicit null check on all values.
    @psychedelicious
    psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ef2b314 View commit details
    Browse the repository at this point in the history

  4. fix(ui): use const EMPTY_OBJECT to prevent rerenders

    @psychedelicious
    psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    39ae1a4 View commit details
    Browse the repository at this point in the history

  5. fix(ui): handle no model selection in default settings tooltip

    @psychedelicious
    psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2a5c137 View commit details
    Browse the repository at this point in the history

  6. feat(ui): disable default settings button when synced 

    A blue button is begging to be clicked, but clicking it will do nothing. Instead, we should communicate that no action is needed by disabling the button when the default settings are already in use.
    @psychedelicious
    psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5e32810 View commit details
    Browse the repository at this point in the history

  7. tweak(ui): default settings verbiage

    @psychedelicious
    psychedelicious committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    eeb064b View commit details
    Browse the repository at this point in the history