Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and flatten Input interfaces and types #474

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

karimodm
Copy link
Contributor

@karimodm karimodm commented Aug 3, 2023

Removed intermediate interface IndexedUTXOReferencer, which could be possibly implemented only by a concrete UTXO input type, in favor of a generic Input interface for which all inputs, including context inputs, are implementations of.
Some methods have also been renamed to become more consistent to what result you are expected to obtain: if you are getting the OutputID of an UTXO output its getter is then called OutputID(), if instead you need to fetch the generic identifier for an Input, no matter what input type this is, then the StateID() getter is provided, with its companion Type() to discern the concrete input contained in the interface.

@karimodm karimodm marked this pull request as ready for review August 8, 2023 09:07
@karimodm karimodm changed the title Unify ContextInput and Input Unify and flatten Input interfaces and types Aug 9, 2023
@piotrm50 piotrm50 self-requested a review August 10, 2023 09:39
@karimodm karimodm merged commit 3fec1b9 into serix-iota-core Aug 10, 2023
4 checks passed
@karimodm karimodm deleted the feat/resolvable-inputs branch August 10, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants