Update IREE third-party/benchmark for RISC-V Compatibility #19538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
reviewed
Dec 20, 2024
ScottTodd
added a commit
that referenced
this pull request
Jan 2, 2025
Context: #19538 (comment) One workflow failed on a self-hosted runner after changing a submodule pin: ``` + git submodule update --init --jobs 8 --depth 1 third_party/benchmark third_party/cpuinfo third_party/flatcc third_party/googletest third_party/hip-build-deps third_party/hsa-runtime-headers third_party/musl third_party/spirv_cross third_party/tracy third_party/vulkan_headers third_party/webgpu-headers From https://github.com/google/benchmark + c19cfee...f4f93b5 main -> origin/main (forced update) From https://github.com/google/benchmark * branch 99bdb2127d1fa1cff444bbefb814e105c7d20c45 -> FETCH_HEAD error: Your local changes to the following files would be overwritten by checkout: .github/workflows/pre-commit.yml .github/workflows/test_bindings.yml ... Please commit your changes or stash them before you switch branches. Aborting fatal: Unable to checkout '99bdb2127d1fa1cff444bbefb814e105c7d20c45' in submodule path 'third_party/benchmark' ``` This adds the `--force` flag to try proceeding anyways. Anyone calling this script is already delegating the submodule update behavior to it.
This PR updates the third-party/benchmark in IREE to address the use of the RDCYCLE instruction on RISC-V. Starting from Linux 6.6[1], RDCYCLE is a privileged instruction and cannot be directly accessed from user space. To ensure compatibility, this update transitions to using RDTIME instead. Use RDTIME instead, which while less accurate has the advantage of being synchronized between CPU (and thus monotonic) and of constant frequency. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc4c07c89aada16229084eeb93895c95b7eabaa3 Signed-off-by: Phoebe Chen <[email protected]>
phoebesv
force-pushed
the
update-gbench
branch
from
4d61d78 to
72896df
Compare
ScottTodd
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the third-party/benchmark in IREE to address the use of the RDCYCLE instruction on RISC-V. Starting from Linux 6.6[1], RDCYCLE is a privileged instruction and cannot be directly accessed from user space. To ensure compatibility, this update transitions to using RDTIME instead.
Use RDTIME instead, which while less accurate has the advantage of being synchronized between CPU (and thus monotonic) and of constant frequency.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc4c07c89aada16229084eeb93895c95b7eabaa3