Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IREE third-party/benchmark for RISC-V Compatibility #19538

Merged
merged 1 commit into from
Jan 3, 2025
+1 −1
Merged

Update IREE third-party/benchmark for RISC-V Compatibility #19538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update IREE third-party/benchmark for RISC-V Compatibility 
This PR updates the third-party/benchmark in IREE to address the use of
the RDCYCLE instruction on RISC-V. Starting from Linux 6.6[1], RDCYCLE is a
privileged instruction and cannot be directly accessed from user space.
To ensure compatibility, this update transitions to using RDTIME
instead.

Use RDTIME instead, which while less accurate has the advantage of being
synchronized between CPU (and thus monotonic) and of constant frequency.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc4c07c89aada16229084eeb93895c95b7eabaa3

Signed-off-by: Phoebe Chen <phoebe.chen@sifive.com>
@phoebesv
phoebesv committed Jan 3, 2025
commit 72896df000ec739222e2c955a3499236a62f6ca1
2 changes: 1 addition & 1 deletion third_party/benchmark
Submodule benchmark updated 17 files
+6 −7 .github/workflows/pre-commit.yml
+5 −5 .github/workflows/test_bindings.yml
+12 −11 .github/workflows/wheels.yml
+3 −3 .pre-commit-config.yaml
+1 −0 CONTRIBUTORS
+3 −3 MODULE.bazel
+11 −3 WORKSPACE
+11 −19 bazel/benchmark_deps.bzl
+9 −5 include/benchmark/benchmark.h
+4 −5 pyproject.toml
+9 −0 setup.py
+4 −4 src/complexity.cc
+6 −5 src/cycleclock.h
+2 −0 src/statistics.cc
+2 −0 src/sysinfo.cc
+1 −1 test/CMakeLists.txt
+1 −1 test/perf_counters_gtest.cc