add dkg round2 function #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defines round2 to take a round1 SecretPackage and a vector of round1 PublicPackages and run round2 of DKG. finds the PublicPackage corresponding to self_identity and uses it to verify the checksums contained in all of the other PublicPackages. iterates over round1 PublicPackages to construct map from identifier to frost package required for frost part2 inputs and to collect group_secret_key_shards moves 'Error' enum from round1 to separate error module to allow reuse across dkg rounds, adds ChecksumError to enum
andiflabs
reviewed
Apr 11, 2024
andiflabs
reviewed
Apr 11, 2024
andiflabs
reviewed
Apr 11, 2024
|
|
||
| for public_package in round1_public_packages { | ||
| if public_package.checksum() != self_public_package.checksum() { | ||
| return Err(Error::ChecksumError(ChecksumError)); |
There was a problem hiding this comment.
Can we provide a more error message? I don't remember how we do it for TKD (if the error message is generated on ironfish-frost, ironfish-rust, ironfish-rust-nodejs, or typescript), but ideally we should use the same pattern.
This doesn't need to be done in this PR though.
There was a problem hiding this comment.
I'll update this in a separate PR since it will affect signing_commitment too
andiflabs
approved these changes
Apr 11, 2024
removes Ord and PartialOrd implementations for PublicPackage that only compare identities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defines round2 to take a round1 SecretPackage and a vector of round1 PublicPackages and run round2 of DKG.
finds the PublicPackage corresponding to self_identity and uses it to verify the checksums contained in all of the other PublicPackages.
iterates over round1 PublicPackages to construct map from identifier to frost package required for frost part2 inputs and to collect group_secret_key_shards
moves 'Error' enum from round1 to separate error module to allow reuse across dkg rounds, adds ChecksumError to enum