Make sure PropertyNames is always populated in AddUserDefinedProperty() #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the code was set up should mean that PropertyNames is never null in UserDefinedProperties containers, so it should never be null when it gets to the
PropertyNames.Any
. However, the compiler can't tell that, so you get nullability warnings in the buildIt might be safe to
!
the references here, but then - I don't think there should be any problem with just creating PropertyNames here so maybe that's the safer approach to take.