Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure PropertyNames is always populated in AddUserDefinedProperty() #214

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Make sure PropertyNames is always populated in AddUserDefinedProperty() #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions OpenMcdf.Ole/OlePropertiesContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ public OleProperty AddUserDefinedProperty(VTPropertyType vtPropertyType, string
if (this.ContainerType != ContainerType.UserDefinedProperties)
throw new InvalidOperationException();

PropertyNames ??= new();

// As per https://learn.microsoft.com/en-us/openspecs/windows_protocols/MS-OLEPS/4177a4bc-5547-49fe-a4d9-4767350fd9cf
// the property names have to be unique, and are case insensitive.
if (PropertyNames.Any(property => property.Value.Equals(name, StringComparison.InvariantCultureIgnoreCase)))
Expand Down