Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Joint Armature and Friction Randomisation Bug #1904

Open
2 of 3 tasks
LeoHurryUp opened this issue Feb 19, 2025 · 2 comments
Open
2 of 3 tasks

[Bug Report] Joint Armature and Friction Randomisation Bug #1904

LeoHurryUp opened this issue Feb 19, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@LeoHurryUp
Copy link

Describe the bug

The _process_actuators_cfg function fails to correctly update the armature and friction properties in the self._data.default_joint_armature and self._data.default_joint_friction dictionary. This omission causes issues when using the randomize_joint_parameters function to randomize the armature with a scale, as the default armature values remain zero, leading to a training crash.

Steps to reproduce

Use the randomize_joint_parameters function to randomize the armature with scale

default_joint_armature:  tensor([[0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        ...,
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.]], device='cuda:0')

System Info

Describe the characteristic of your environment:

  • Commit: 6a415df
  • Isaac Sim Version: 4.5
  • OS: Ubuntu 22.04
  • GPU: RTX 3090
  • CUDA: 12.4
  • GPU Driver: 550.120

Additional context

Add the following code

self._data.default_joint_armature[:, actuator.joint_indices] = actuator.armature
self._data.default_joint_friction[:, actuator.joint_indices] = actuator.friction

after

# Store the actual default stiffness and damping values for explicit and implicit actuators (not written the sim)
self._data.default_joint_stiffness[:, actuator.joint_indices] = actuator.stiffness
self._data.default_joint_damping[:, actuator.joint_indices] = actuator.damping

would be helpful.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have checked that the issue is not in running Isaac Sim itself and is related to the repo

Acceptance Criteria

Add the criteria for which this task is considered done. If not known at issue creation time, you can add this once the issue is assigned.

  • Update the _process_actuators_cfg function to include the missing lines for armature and friction.
@RandomOakForest
Copy link
Collaborator

Thanks for posting this. The team will investigate.

@RandomOakForest RandomOakForest added the bug Something isn't working label Feb 19, 2025
@Mayankm96
Copy link
Contributor

This is under works here: #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants