-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add maven release #513
add maven release #513
Conversation
@it-at-m/sps zur Info |
@ejcsid has the same opinion as me |
@devtobi I would do the wrapper in a separate issue because you have in other workflows the same problem https://github.com/it-at-m/refarch-templates/blob/43-actions-to-create-releases/.github/workflows/maven-node-build.yaml#L23 I would do all together. so this mr is ready to merge |
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce a new GitHub Actions workflow file named Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
📒 Files selected for processing (1)
.github/workflows/release-maven-image.yaml
(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/release-maven-image.yaml
[warning] 3-3: truthy value should be one of [false, true]
(truthy)
[warning] 29-29: too few spaces before comment
(comments)
[error] 63-63: wrong indentation: expected 10 but found 9
(indentation)
🔇 Additional comments (1)
.github/workflows/release-maven-image.yaml (1)
32-40
: Verify secrets availability
The Maven release step requires several sensitive credentials.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now, further improvements and ideas will be resolved in separate issues
it-at-m/.github#82 hier das separate issue |
Description
Short description or comments
Reference
Issues it-at-m/.github#43
Summary by CodeRabbit