Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maven release #513

Merged
merged 11 commits into from
Dec 2, 2024
Merged

add maven release #513

merged 11 commits into from
Dec 2, 2024

Conversation

hupling
Copy link
Contributor

@hupling hupling commented Nov 14, 2024

Description

Short description or comments

Reference

Issues it-at-m/.github#43

Summary by CodeRabbit

  • New Features
    • Introduced a new automated workflow for releasing Maven applications, including building Docker images and creating GitHub releases.
    • Users can manually trigger the release process with specified version inputs and application paths.

@hupling hupling linked an issue Nov 14, 2024 that may be closed by this pull request
5 tasks
@hupling
Copy link
Contributor Author

hupling commented Nov 14, 2024

@it-at-m/sps zur Info

@devtobi devtobi self-requested a review November 15, 2024 10:50
.github/workflows/release-maven-image.yaml Outdated Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Outdated Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Show resolved Hide resolved
@hupling
Copy link
Contributor Author

hupling commented Nov 18, 2024

@ejcsid has the same opinion as me

@simonhir simonhir changed the title add mvane release add maven release Nov 28, 2024
@hupling
Copy link
Contributor Author

hupling commented Nov 29, 2024

@devtobi I would do the wrapper in a separate issue because you have in other workflows the same problem https://github.com/it-at-m/refarch-templates/blob/43-actions-to-create-releases/.github/workflows/maven-node-build.yaml#L23

I would do all together. so this mr is ready to merge

@hupling hupling marked this pull request as ready for review November 29, 2024 08:43
@hupling hupling requested a review from a team as a code owner November 29, 2024 08:43
Copy link

coderabbitai bot commented Nov 29, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new GitHub Actions workflow file named release-maven-image.yaml. This workflow automates the release process for a Maven-based application, triggered manually with specific inputs for release and development versions, as well as the application path. It consists of three main jobs: release-maven, which handles the Maven release; build-image, which builds a Docker image; and create-github-release, which creates a GitHub release based on the Maven artifact.

Changes

File Change Summary
.github/workflows/release-maven-image.yaml New workflow file added to automate Maven release, Docker image build, and GitHub release creation.

Possibly related PRs

  • add maven release #513: This PR introduces the same GitHub Actions workflow file release-maven-image.yaml and contains identical changes, indicating a direct match with the main PR.

Poem

In the meadow where the code does play,
A new workflow hops in, brightening the day.
With Maven and Docker, it dances in line,
Creating releases, oh how they shine! 🐇✨
A joyful release, let the bunnies cheer,
For automation's here, bringing us near!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 9968215 and 5dfe001.

📒 Files selected for processing (1)
  • .github/workflows/release-maven-image.yaml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hupling hupling enabled auto-merge (squash) November 29, 2024 08:45
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 7166150 and 9968215.

📒 Files selected for processing (1)
  • .github/workflows/release-maven-image.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/release-maven-image.yaml

[warning] 3-3: truthy value should be one of [false, true]

(truthy)


[warning] 29-29: too few spaces before comment

(comments)


[error] 63-63: wrong indentation: expected 10 but found 9

(indentation)

🔇 Additional comments (1)
.github/workflows/release-maven-image.yaml (1)

32-40: Verify secrets availability

The Maven release step requires several sensitive credentials.

.github/workflows/release-maven-image.yaml Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Outdated Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Show resolved Hide resolved
.github/workflows/release-maven-image.yaml Outdated Show resolved Hide resolved
hupling and others added 3 commits December 2, 2024 12:54
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@DanielOber DanielOber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, further improvements and ideas will be resolved in separate issues

@hupling hupling merged commit 3bbfcfa into main Dec 2, 2024
10 checks passed
@hupling hupling deleted the 43-actions-to-create-releases branch December 2, 2024 12:24
@hupling
Copy link
Contributor Author

hupling commented Dec 2, 2024

it-at-m/.github#82 hier das separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions to create Releases
4 participants