increase timeout of test for windows #405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
ba4343f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d6d9c1e.datachain-documentation.pages.dev |
| Branch Preview URL: | https://increase-timeout.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 87.31% 87.31%
=======================================
Files 92 92
Lines 9982 9982
Branches 2041 2041
=======================================
Hits 8716 8716
Misses 911 911
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Given that the 3.9 job finishes in ~19mins, the other job is most likely frozen, and we should investigate instead of increasing timeout. |
|
I think it is just luck of the draw with the windows runner that we pull. Some perform like dog shit and take 4x longer than a normal runner. The job was 92% of the way through. |
|
It could be E2E tests too, that are frozen. We can add |
mattseddon
force-pushed
the
increase-timeout
branch
from
f019d7b to
6ef50a3
Compare
mattseddon
force-pushed
the
increase-timeout
branch
from
6ef50a3 to
ba4343f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another failure here: https://github.com/iterative/datachain/actions/runs/10750425347/job/29816550855?pr=403
There is some more investigation and discussion in #406