-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timeout to e2e tests #406
Conversation
Deploying datachain-documentation with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 87.31% 86.88% -0.43%
==========================================
Files 92 92
Lines 9981 9982 +1
Branches 2041 1900 -141
==========================================
- Hits 8715 8673 -42
- Misses 911 947 +36
- Partials 355 362 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm investigating here: https://github.com/iterative/datachain/actions/runs/10770282498. I will merge this if E2E is the problem. |
It looks like the issue is with parallel udf tests. Although I am not sure, but adding Need to check if the crashes happen on |
* fixes settings * drop settings from listings * is_pydantic check for class --------- Co-authored-by: Matt Seddon <[email protected]>
69adca0
to
0f028d7
Compare
0f028d7
to
46aa438
Compare
From the docs: "For each test item the pytest-timeout plugin starts a timer thread which will terminate the whole process after the specified timeout. When a test item finishes this timer thread is cancelled and the test run continues." so these tests are timing out. Adding I am still seeing runs > 35 minutes long (here) even with tests getting killed after the timeout. Given this and the fact that the original run in question from #405 was at 92% completed with 4 workers, I do not think it is unfeasible that the entire suite is just running slowly and needs > 40 minutes to complete. |
Check the timestamp on https://github.com/iterative/datachain/actions/runs/10750425347/job/29816550855?pr=403. The second-to-last line is at 10-minute mark and the last line appears 30 minutes later when the job times out. |
From #405 (comment)