Workspace with the Gazebo World #30
Conversation
There was a problem hiding this comment.
Thanks for the PR! Most changes look good to me, but I'm curious about the decision on using Google Drive (commits 6150ccf, 4564568, 8659a83) instead of tracking the files in Git.
I prefer tracking files in Git unless it would cause significant issues, like large files making Git clones excessively slow.
The total file size here seems to be around a few hundred MB when compressed. I think we can simply track them in Git?
|
Tracking models in Git seems a bit unusual since it implies tracking model weights or something similar, which we typically wouldn't modify manually. However, I'm not too keen on using Google Drive either. I might want to try the method in this repository ( assets.zip ) in the future. What do you think? If we want to revert to using Git to track the model, we just need to delete a few commits and make some minor adjustments. It's not a difficult task. I can make the change now, and we can explore it further when we have more time or opportunity in the future. |
|
Yeah I think we can revert to track models in Git for now. Thank you! We can explore better methods in the future. (further discussions in #42) |
YuZhong-Chen
force-pushed
the
gazebo_world_ws
branch
from
e1591db to
78e16a8
Compare
This package is designed for opening Gazebo.
…in citysim. The original repository is not designed for ROS, so the package structure differs from a typical package.
To ensure Gazebo's satisfaction, remove the plugin from the world file, as we won't be building those plugins.
…ts.txt in turtlebot3_gazebo. As we solely require the world file and won't use the TurtleBot3, it's likely unnecessary to build the TurtleBot3 driver.
YuZhong-Chen
force-pushed
the
gazebo_world_ws
branch
from
78e16a8 to
4d6d6c8
Compare
…ital_world. Since we have downloaded the model and track the model by Git, there's no need to execute the download program in the package build process.
YuZhong-Chen
force-pushed
the
gazebo_world_ws
branch
from
4d6d6c8 to
3d8daf4
Compare
Copy the world file from clearpath repo. (Husky) Reference: - https://github.com/husky/husky/blob/1e0b1d14d657f04ec3a86e73d6676a2cf7af6f79/husky_gazebo/worlds/clearpath_playpen.world
Co-authored-by: Johnson Sun <[email protected]>
YuZhong-Chen
force-pushed
the
gazebo_world_ws
branch
from
3d8daf4 to
2d4d8cc
Compare
…gzclient. If gzclient is not launched, it will run in headless mode without opening the GUI. This is useful when running the code on a server or when the GUI is not needed.
Allow the user to select the TurtleBot3 world file when launching the simulation.
…st format of `template_ws`.
|
Since workspaces like |
The source `clearpath_playpen.world` file retrieved by `wget` has a trailing newline. Just a small modification to keep them in sync.
Achieving the same objective as in #6, but incorporating two additional worlds.
In contrast to the previous pull request, I've opted not to use the git submodule. This decision stems from the potential need to modify the world file in future projects, such as incorporating additional plugins.