Removing Masterminds/goutils from go.mod #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masterminds/goutils isn't a direct dependency for carta but for testdata/initdb. goutils is currently being flagged by dependabot. Also cleaned up contributing doc a little and added initdb make target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masterminds/goutils isn't a direct dependency for carta but indirect github.com/Masterminds/sprig in for testdata/initdb/server.go. goutils is currently being flagged by dependabot - GHSA-xg2h-wx96-xgxr.
Alternately - could bump goutils to v1.1.1, but as mentioned I seem to be able to build/test without it.
Also cleaned up contributing doc a little and added initdb make target
(I'm breaking my rule of a PR focusing on one specific thing - if you want Makefile and CONTRIBUTORS.md in a separate PR, lemme know.)