Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Masterminds/goutils from go.mod #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing Masterminds/goutils from go.mod #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,20 @@ The recommended PR process is as follows.
2. Upgrade with `go get -u github.com/jackskj/carta`
3. cd `$GOPATH/src/github.com/jackskj/carta`
4. Reflect your changes in example files as well as the README.
5. You can use gazelle functions (gazelle, repos, and fix) from the Makefile.
6. Make sure that the build succedes with `go build` or `make build`
5. Make sure that the build succedes with `go build` or `make build`
and all tests pass with `make test`
7. Make sure to follow [Effective Go](https://golang.org/doc/effective_go.html)
6. Make sure to follow [Effective Go](https://golang.org/doc/effective_go.html)
as well as [Go Code Review Comments](https://golang.org/wiki/CodeReviewComments)

## Code of Conduct

## Testing
Go tests can be run via make by executing `make test`.

Prior to running unit tests, ensure postgres and mysql database containers are running by executing `make testdbs`.

Before running `make test` for the first time, you will need to create the database structure by running `make initdb`.

## Code of Conduct

Please do not make aggressive, harassing or condescending comments based on someone's
age, body size, disability, ethnicity, gender identity and expression, level of experience,
Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ install:
# generating map binary in $$GOPATH/bin
go install .

initdb:
go test -v -initdb

test:
go test -v

Expand Down
1 change: 0 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module github.com/jackskj/carta
go 1.14

require (
github.com/Masterminds/goutils v1.1.0 // indirect
github.com/Masterminds/semver v1.5.0 // indirect
github.com/Masterminds/sprig v2.22.0+incompatible
github.com/go-sql-driver/mysql v1.5.0
Expand Down