Enable Lint Rule: modifies-value-receiver

[FlamingSaint]

Which problem is this PR solving?

• Partial Fix for Enable more revive linter rules #5506

Description of the changes

• Enabled modifies-value-receiver in revive linter.
• Removed instances where pass-by-values where re-assigned and returned.

How was this change tested?

• make lint make test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (f2b46d4) to head (5fa0a61).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5517   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         327      327           
  Lines       16012    16014    +2     
=======================================
+ Hits        15403    15405    +2     
  Misses        435      435           
  Partials      174      174           

Flag	Coverage Δ
badger_v1	8.05% <0.00%> (-0.01%)	⬇️
badger_v2	1.93% <0.00%> (-0.01%)	⬇️
cassandra-3.x-v1	16.44% <50.00%> (+0.01%)	⬆️
cassandra-3.x-v2	1.85% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v1	16.44% <50.00%> (+0.01%)	⬆️
cassandra-4.x-v2	1.85% <0.00%> (-0.01%)	⬇️
elasticsearch-7-v1	18.87% <0.00%> (-0.02%)	⬇️
elasticsearch-8-v1	19.07% <0.00%> (-0.02%)	⬇️
elasticsearch-8-v2	19.08% <0.00%> (-0.01%)	⬇️
grpc_v1	9.48% <0.00%> (-0.01%)	⬇️
grpc_v2	7.53% <0.00%> (-0.01%)	⬇️
kafka	9.78% <0.00%> (-0.01%)	⬇️
opensearch-1-v1	18.93% <0.00%> (-0.01%)	⬇️
opensearch-2-v1	18.93% <0.00%> (-0.01%)	⬇️
opensearch-2-v2	18.93% <0.00%> (-0.01%)	⬇️
unittests	93.89% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

in both cases you changes the existing semantics of the functions. Instead, you can find a way to keep the semantics while satisfying the linter.

[FlamingSaint]

in both cases you changes the existing semantics of the functions. Instead, you can find a way to keep the semantics while satisfying the linter.

Are the changes okay ?