Enable Lint Rule: modifies-value-receiver

.golangci.yml

@@ -189,9 +189,6 @@ linters-settings:
         # TBD - often triggered in tests
         - name: unhandled-error
           disabled: true
-        # this one looks like it's catching real errors, need to enable it
-        - name: modifies-value-receiver
-          disabled: true
         # often looks like a red herring, needs investigation
         - name: flag-parameter
           disabled: true

cmd/agent/app/builder.go

@@ -166,7 +166,7 @@ func (b *Builder) getProcessors(rep reporter.Reporter, mFactory metrics.Factory,
 }
 
 // GetHTTPServer creates an HTTP server that provides sampling strategies and baggage restrictions to client libraries.
-func (c HTTPServerConfiguration) getHTTPServer(manager configmanager.ClientConfigManager, mFactory metrics.Factory, logger *zap.Logger) *http.Server {
+func (c *HTTPServerConfiguration) getHTTPServer(manager configmanager.ClientConfigManager, mFactory metrics.Factory, logger *zap.Logger) *http.Server {
 	if c.HostPort == "" {
 		c.HostPort = defaultHTTPServerHostPort
 	}

model/dependencies.go

@@ -21,9 +21,8 @@ const (
 )
 
 // ApplyDefaults applies defaults to the DependencyLink.
-func (d DependencyLink) ApplyDefaults() DependencyLink {
+func (d *DependencyLink) ApplyDefaults() {
 	if d.Source == "" {
 		d.Source = JaegerDependencyLinkSource
 	}
-	return d
 }

model/dependencies_test.go

@@ -21,10 +21,12 @@ import (
 )
 
 func TestDependencyLinkApplyDefaults(t *testing.T) {
-	dl := DependencyLink{}.ApplyDefaults()
+	dl := DependencyLink{}
+	dl.ApplyDefaults()
 	assert.Equal(t, JaegerDependencyLinkSource, dl.Source)
 
 	networkSource := "network"
-	dl = DependencyLink{Source: networkSource}.ApplyDefaults()
+	dl = DependencyLink{Source: networkSource}
+	dl.ApplyDefaults()
 	assert.Equal(t, networkSource, dl.Source)
 }

plugin/storage/cassandra/dependencystore/storage.go

@@ -126,7 +126,8 @@ func (s *DependencyStore) GetDependencies(ctx context.Context, endTs time.Time,
 				Child:     dependency.Child,
 				CallCount: uint64(dependency.CallCount),
 				Source:    dependency.Source,
-			}.ApplyDefaults()
+			}
+			dl.ApplyDefaults()
 			mDependency = append(mDependency, dl)
 		}
 	}