Type check #232
Merged
Type check #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 18, 2024 17:07
This was referenced Dec 5, 2024
This was referenced Dec 26, 2024
jameskermode
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #230 and #231
Update the type check feature that checks the Python types that are passed to Fortran routines.
Improves #182:
When the wrapper is not wrapping a Fortran interface, use numpy
astypemember function to convert types to the right size. For instance, int32 to int64. This makes the Python wrapper interfaces more Pythonic.When the wrapper is wrapping a Fortran interface, the behavior stays the same, strict type matching between Python input type and the Fortran signature is required so that the correct Fortran routine is called.