Secret feature #11
Open
Secret feature #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ATTN @jjb |
| status 200 | ||
| "ok" | ||
| JSON.pretty_generate(settings.config) |
There was a problem hiding this comment.
i was thinking if the user didn't secure their app then we don't want to dump this
if we don't have that logic, then we should probably just require a secret. which seems reasonable.
|
looks good! feel free to squish with my commit. (i'd probably do it in 2 or 3 individual commits, separating the new functionality from the upgrade stuff). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this replaces #9