option to require secret #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
n.b. i didn't have ruby 2.0.0 available on my machine so i did dev in 2.3.1. Also, for some reason json wasn't building on my machine with the Gemfile.lock as it was, so I did a The only possible consequence of this I can think of is that maybe the json in the Gemfile.lock doesn't support In any case I think we can safely bump up the ruby version, or maybe even don't specify it at all? Heroku doesn't even support ruby 1.9 any more I believe. |
Open
|
Does this fit your bill #11 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature discussed in #6
@deadlyicon @rmm5t Let me know what you think! Any feedback on code or copy is welcome.