Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jdk-17 required #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fcojfernandez
Copy link
Member

@fcojfernandez fcojfernandez commented Jan 3, 2025

PR to make JDK-17 required and upgrade the parent pom to unblock #491

Changing from javaee to jakarta will be still part of #491

Testing done

Clean-up work, so just make sure existing tests are passing

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@fcojfernandez fcojfernandez changed the title Make required jdk-17 Make jdk-17 required Jan 3, 2025
@fcojfernandez fcojfernandez marked this pull request as ready for review January 3, 2025 12:55
@fcojfernandez fcojfernandez requested a review from a team as a code owner January 3, 2025 12:55
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (84359ac) to head (acd29f6).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #496   +/-   ##
=========================================
  Coverage     71.73%   71.73%           
  Complexity      222      222           
=========================================
  Files            17       17           
  Lines          1033     1033           
  Branches        148      148           
=========================================
  Hits            741      741           
  Misses          201      201           
  Partials         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted from #455 (as opposed to #491), but not correctly:

  • Additions of commons-lang3-api and commons-text-api are part of the pac4j library upgrade (because pac4j 6.x depends on these Apache Commons libraries, but not pac4j 5.x) and not the Java upgrade; therefore, these changes make no sense in a Java upgrade PR
  • Ditto for addition of Jackson exclusions
  • Ditto for removal of Guava exclusion
  • Missing Co-authored-by: Basil Crow <[…]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants