[JENKINS-75056] Upgrade pac4j to version 6.1.0 #491
Conversation
| } | ||
|
|
||
| /** | ||
| * This method is needed as there seems to be a bug in pac4j and hasChanged is not able to return true |
There was a problem hiding this comment.
I am curious: Is there an official bug report link? Maybe helpful to add this here...
There was a problem hiding this comment.
There was a problem hiding this comment.
This method is needed
Is this statement true? It was not needed in #455.
| if (res != null) { | ||
| res.sendRedirect(Jenkins.get().getSecurityRealm().getLoginUrl()); | ||
| } | ||
| res.sendRedirect(Jenkins.get().getSecurityRealm().getLoginUrl()); |
There was a problem hiding this comment.
I added the null check on purpose (see https://github.com/jenkinsci/oic-auth-plugin/releases/tag/4.438.v6e62f6782770).
Suggestion: add @NonNull to the parameters to tighten the contract.
src/main/java/org/jenkinsci/plugins/oic/OicdPluginOpMetadataResolver.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * This method is needed as there seems to be a bug in pac4j and hasChanged is not able to return true |
There was a problem hiding this comment.
fcojfernandez
changed the title
… like jackson lib coming from jackson2 plugin
pankajy-dev
changed the title
…solver.java Co-authored-by: Francisco Javier Fernandez <[email protected]>
|
I wonder if this PR super-seeds #455? |
Yes, seems like the same change. |
|
CI is failing as pom uses 5.3 version of plugin-pom which needs min maven 3.9.6 I think CI needs an update to use the updated Maven version. |
|
Depends on #485 |
There was a problem hiding this comment.
File introduced in fc9ee86, but why? https://github.com/jenkins-infra/pipeline-library/?tab=readme-ov-file#buildplugin already supports recording code coverage in the Jenkins build.
|
There is another PR for same changes with passing CI, therefore this PR will be closed in favor of #455 |
|
@pankajy-dev this PR should unblock you #496 |
| - name: Generate coverage with JaCoCo | ||
| run: mvn --batch-mode clean verify jacoco:prepare-agent test integration-test jacoco:report | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
| uses: codecov/codecov-action@v4 |
There was a problem hiding this comment.
please don't downgrade anything
Testing done
Executed all the Junit tests
Executed OicAuthPluginTest
The plugin is compiling and passing all the tests.
Jenkins issue 75056
Submitter checklist