Realloc instructions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
program/src/realloc_ballot_box.rs
Outdated
| realloc(ballot_box, new_size, payer, &Rent::get()?)?; | ||
| } | ||
|
|
||
| if ballot_box.data_len() >= BallotBox::SIZE |
There was a problem hiding this comment.
nit suggestion - which could be applied to all realloc functions:
let should_initailize = ballot_box.data_len() >= BallotBox::SIZE && ballot_box.try_borrow_data()?[0] != BallotBox::DISCRIMINATOR
if should_initailize {
ballot_box.initalize()
}
| let current_slot = Clock::get()?.slot; | ||
| let (_, ncn_epoch_length) = load_ncn_epoch(restaking_config, current_slot, None)?; | ||
|
|
||
| //TODO move to helper function |
There was a problem hiding this comment.
This is a good argument for the suggested nit above.
coachchucksol
approved these changes
Dec 17, 2024
| let current_slot = Clock::get()?.slot; | ||
| let (_, ncn_epoch_length) = load_ncn_epoch(restaking_config, current_slot, None)?; | ||
|
|
||
| //TODO move to helper function |
program/src/route_ncn_rewards.rs
Outdated
| @@ -65,8 +63,12 @@ pub fn process_route_ncn_rewards( | |||
|
|
|||
| let rent_cost = ncn_reward_router_account.rent_cost(&Rent::get()?)?; | |||
|
|
|||
| msg!("A"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes to self