Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion: suggest file paths incrementally #4895

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Nov 17, 2024

stacked on #4887 (teach commands about files)

If there are multiple files in a subdirectory that are candidates for completion, only complete the common directory prefix to reduce the number of completion candidates shown at once.

This matches the normal shell completion of file paths.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@senekor senekor force-pushed the remo/mknomzkwyqpz branch 6 times, most recently from b6b10a1 to ccbcdf3 Compare November 17, 2024 17:08
@senekor senekor mentioned this pull request Nov 17, 2024
4 tasks
cli/src/complete.rs Show resolved Hide resolved
cli/src/complete.rs Outdated Show resolved Hide resolved
@senekor senekor force-pushed the remo/vxqolomwrqtw branch 2 times, most recently from 4b076bb to c3335a6 Compare November 18, 2024 12:23
@senekor senekor force-pushed the remo/vxqolomwrqtw branch 7 times, most recently from 697fd99 to d295af2 Compare November 27, 2024 17:54
Base automatically changed from remo/vxqolomwrqtw to main November 28, 2024 14:34
@senekor senekor force-pushed the remo/mknomzkwyqpz branch 3 times, most recently from 06822e3 to eb0d240 Compare November 29, 2024 19:24
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

cli/src/complete.rs Outdated Show resolved Hide resolved
cli/src/complete.rs Outdated Show resolved Hide resolved
cli/src/complete.rs Outdated Show resolved Hide resolved
cli/src/complete.rs Outdated Show resolved Hide resolved
If there are multiple files in a subdirectory that are candidates for
completion, only complete the common directory prefix to reduce the number of
completion candidates shown at once.

This matches the normal shell completion of file paths.
@senekor senekor merged commit a8c35db into main Dec 1, 2024
31 checks passed
@senekor senekor deleted the remo/mknomzkwyqpz branch December 1, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants