-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fix for issue #182 Thread safety #261
base: main
Are you sure you want to change the base?
Conversation
cdf83f5
to
0c8eea7
Compare
…l for waterfall charts).
… workbook generation.
a5cb6d7
to
7dda1e3
Compare
This PR might still need some work as File::Path::rmdir does not work well under threads on recent Windows perls. On Strawberry Perl 5.38.2.2 I get the warnings below, and the temp dirs are not cleaned up. A fallback to File::Path::Tiny might work. I know it has been discussed in #182 but local testing shows it cleans up the temp dirs when run under threads. See also discussion under StrawberryPerl/Perl-Dist-Strawberry#146
|
This pull request provides a test for multi-threaded workbook creation, code modifications to enable the test to pass, updated POD documentation, and an example script demonstrating multi-threaded workbook creation.