feat: add liveness + readiness Probe to deployment #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I hate hard-coded values so much that I just set up a containerPort in the values-file which shouldn't have any effect and most likely is never overriden but replaces the hard-coded values in service, livenessProbe, readinessProbe and the container.port itself :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
I usually dislike hard-coded ports and thought about creating a value containerPort or something similar for it (and referencing it in the service as well) but for now decided to use the hard-coded value as of now.If you would like that more please let me know and I'll adjust it because otherwise it might get lost in future regressionssee 2nd commit/comment lol
closes #162