Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with OMADA plyging with ip detection sometimes breaking. #894

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

Leicas
Copy link

@Leicas Leicas commented Nov 24, 2024

No description provided.

Copy link

gitguardian bot commented Nov 24, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13089635 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089635 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089638 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089639 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Leicas
Copy link
Author

Leicas commented Nov 24, 2024

Was initially looking if my problem could be the same as the issue listed here #882 but after switching to the dev container I made a few modifications to make the detection work with my setup.

After some test I discovered it would not find the right default gateway and would choose loopback, I don’t know if it’s because I’m using more than one network (vlans to be precise). But with the modifications here it works, it should also still work for anyone having the issue before.

Could also be related to #825 ?

@jokob-sk
Copy link
Owner

Thanks a lot @Leicas ! - @FlyingToto can you have look and test this PR on your setup?

@jokob-sk
Copy link
Owner

jokob-sk commented Dec 1, 2024

@FlyingToto I will merge and if needed we can fix/revert

@jokob-sk jokob-sk merged commit d2ad356 into jokob-sk:main Dec 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants