Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with OMADA plyging with ip detection sometimes breaking. #894

Merged
merged 1 commit into from
Dec 1, 2024

Fix for issue with ip detection sometimes breaking.

96be21f
Select commit
Loading
Failed to load commit list.
Merged

Fix for issue with OMADA plyging with ip detection sometimes breaking. #894

Fix for issue with ip detection sometimes breaking.
96be21f
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Nov 24, 2024 in 31s

8 secrets uncovered!

8 secrets was uncovered from the scan of 1 commit in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #894: main 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
13089635 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089635 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089637 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089638 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret
13089639 Triggered Generic High Entropy Secret 96be21f front/plugins/omada_sdn_imp/omada_sdn.py View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.