Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #1

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Suggestions #1

merged 3 commits into from
Sep 24, 2024

Conversation

deanmlittle
Copy link
Contributor

@deanmlittle deanmlittle commented Sep 24, 2024

Made a few changes, let me know what you think!

  1. removed unnecessary section names (ie: only include what the linker requires to build it)
  2. replaced .asciz with .ascii as, according to the Assembly Directives documentation, .asciz seems to add an additional zero byte to the binary we don't particularly need.

- replaced .asciz with .ascii to avoid an additional zero byte allocation
- removed unnecessary section headers not needed by linker
- added extern section for importing sol_log_
removed leading .
Seems we don't need the extern declaration after all!
Copy link
Owner

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks great!

.message:
.asciz "Hello world!"
.rodata
message: .ascii "Hello world!"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn that I used .asciz for a reason, but now I can't remember that reason, so let's do it!

@joncinque joncinque merged commit 19b3947 into joncinque:main Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants