Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #1

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Suggestions #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
155eac8
Update main.s
deanmlittle Sep 24, 2024
033a8ca
Update main.s
deanmlittle Sep 24, 2024
79a2461
Update main.s
deanmlittle Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions helloworld/asm/main.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
.text
.globl entrypoint
.globl entrypoint
entrypoint:
lddw r1, .message
mov64 r2, 12
call sol_log_
exit
.section .rodata
.message:
.asciz "Hello world!"
.rodata
message: .ascii "Hello world!"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn that I used .asciz for a reason, but now I can't remember that reason, so let's do it!