Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [Validation] Fix backend menu items with role="menuitem" not placed inside element with role="menu" #21150

Merged
merged 2 commits into from
Jul 17, 2018

Conversation

ggppdk
Copy link
Contributor

@ggppdk ggppdk commented Jul 16, 2018

Pull Request for Issue # .

Summary of Changes

Backend menu items with role="menuitem" should be placed inside element with role="menubar" or role="menu"

Testing Instructions

  1. Code review
  2. Validate backend, no more errors like:

An element with “role=menuitem” must be contained in, or owned by, an element with “role=menubar” or “role=menu”

Expected result

No error about “role=menubar” or “role=menu” missing

Actual result

The above error

Documentation Changes Required

None

@brianteeman
Copy link
Contributor

this is correct but i thought we had already done this before

@ggppdk
Copy link
Contributor Author

ggppdk commented Jul 16, 2018

There is an older issue about this
#19763

maybe this was meant to be done in a PR together with more accessibility changes

@brianteeman
Copy link
Contributor

I knew it sounded familiar ;)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on e17d4f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jul 16, 2018

I have tested this item ✅ successfully on e17d4f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.

@Quy
Copy link
Contributor

Quy commented Jul 16, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 16, 2018
@zwiastunsw
Copy link
Contributor

This is a different version of the admin menu from the one discussed here:
Joomla 4 Admin menu
I am confused. The current version does not work well.

@laoneo laoneo added this to the Joomla 4.0 milestone Jul 17, 2018
@laoneo laoneo merged commit 065fd0f into joomla:4.0-dev Jul 17, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 17, 2018
@laoneo
Copy link
Member

laoneo commented Jul 17, 2018

@zwiastunsw when you think something is wrong, please open a new issue. Thanks.

@ggppdk ggppdk deleted the patch-66 branch July 17, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants