Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into openapi #1615

Merged
merged 92 commits into from
Oct 1, 2024
Merged

Merge master into openapi #1615

merged 92 commits into from
Oct 1, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Oct 1, 2024

Merges the master branch into openapi, which contains stricter rules for code quality.
Aside from the merge, this PR adds extra commits to make the OpenAPI code compliant.

QUALITY CHECKLIST

bkoelman and others added 30 commits July 20, 2024 11:39
- CA2254: Template should be a static expression
- CA1848: use the LoggerMessage delegates
dependabot bot and others added 24 commits October 1, 2024 09:37
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 87.12121% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (be9165b) to head (abfc8c8).

Files with missing lines Patch % Lines
...les/DapperExample/Repositories/DapperRepository.cs 30.00% 13 Missing and 1 partial ⚠️
...ameworkExample/Services/InMemoryResourceService.cs 66.66% 0 Missing and 2 partials ⚠️
...TranslationToSql/DataModel/BaseDataModelService.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1615      +/-   ##
===========================================
- Coverage    90.61%   90.54%   -0.08%     
===========================================
  Files          455      455              
  Lines        13603    13723     +120     
  Branches      2104     2116      +12     
===========================================
+ Hits         12326    12425      +99     
- Misses         872      881       +9     
- Partials       405      417      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review October 1, 2024 13:16
@bkoelman bkoelman merged commit 0a3fa63 into openapi Oct 1, 2024
16 checks passed
@bkoelman bkoelman deleted the merge-master-into-openapi branch October 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant