Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master into openapi #1615

Merged
merged 92 commits into from
Oct 1, 2024
Merged

Merge master into openapi #1615

merged 92 commits into from
Oct 1, 2024

Commits on Jul 20, 2024

  1. Fix casing in documentation

    @bkoelman
    bkoelman committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    65caf47 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Bump dotnet-reportgenerator-globaltool from 5.3.7 to 5.3.8 (#1598)

    @dependabot
    dependabot[bot] authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    626e74a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Bump jetbrains.resharper.globaltools from 2024.1.4 to 2024.1.6 (#1604)

    @bkoelman
    bkoelman authored Aug 18, 2024
    Configuration menu
    Copy the full SHA
    8e81f71 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Reindent dependabot.yml

    @bkoelman
    bkoelman committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    1e2d4f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Bump dotnet-reportgenerator-globaltool from 5.3.8 to 5.3.9 (#1607)

    @dependabot
    dependabot[bot] authored Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4404e89 View commit details
    Browse the repository at this point in the history

  2. Wrap faker.Generate methods, so that a non-nullable return type is in… 

    …ferred
    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d1ac6d6 View commit details
    Browse the repository at this point in the history

  3. Turn off CA1822: Mark members as static

    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    08e1767 View commit details
    Browse the repository at this point in the history

  4. In tests, turn off CA1707: Identifiers should not contain underscores

    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0ba5650 View commit details
    Browse the repository at this point in the history

  5. Turn off CA1305: Specify IFormatProvider

    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7a5f8b1 View commit details
    Browse the repository at this point in the history

  6. Turn off CA1725: Parameter names should match base declaration

    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b22c7f8 View commit details
    Browse the repository at this point in the history

  7. Turn off CA1720: Identifier contains type name

    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    796bbbf View commit details
    Browse the repository at this point in the history

  8. Turn off CA1716: Identifiers should not match keywords

    @bkoelman
    bkoelman committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    381fcca View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Use source-generated structured logging, fixes rules: 

    - CA2254: Template should be a static expression
- CA1848: use the LoggerMessage delegates
    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e902ff2 View commit details
    Browse the repository at this point in the history

  2. Fix CA1001: Types that own disposable fields should be disposable

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f81ec66 View commit details
    Browse the repository at this point in the history

  3. Fix CA1860: Avoid using 'Enumerable.Any()' extension method

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bbbec9e View commit details
    Browse the repository at this point in the history

  4. Fix CA1309: Use ordinal string comparison

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6ff25b1 View commit details
    Browse the repository at this point in the history

  5. Fix CA1304: Specify CultureInfo

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    adeea31 View commit details
    Browse the repository at this point in the history

  6. Fix CA1051: Do not declare visible instance fields

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ab1616b View commit details
    Browse the repository at this point in the history

  7. Fix CA1512: Use ArgumentOutOfRangeException throw helper

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8fcb14d View commit details
    Browse the repository at this point in the history

  8. Fix CA1513: Use ObjectDisposedException throw helper

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f693a66 View commit details
    Browse the repository at this point in the history

  9. Suppress violations of CA1829: Use Length/Count property instead of C… 

    …ount() when available
    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    44fc8b0 View commit details
    Browse the repository at this point in the history

  10. Fix CA1841: Prefer Dictionary.Contains method

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0aa6334 View commit details
    Browse the repository at this point in the history

  11. Fix CA1854: Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' me… 

    …thod
    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b9ebc30 View commit details
    Browse the repository at this point in the history

  12. Fix CA2201: Do not raise reserved exception types

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    10a9e15 View commit details
    Browse the repository at this point in the history

  13. Suppress violation of CA1711: Identifiers should not have incorrect s… 

    …uffix
    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    978d9ec View commit details
    Browse the repository at this point in the history

  14. Fix CA1859: Use concrete types when possible for improved performance

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6c5e2ff View commit details
    Browse the repository at this point in the history

  15. Fix CA1826: Do not use Enumerable methods on indexable collections

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    adbd98d View commit details
    Browse the repository at this point in the history

  16. Activate and fix CA1033: Interface methods should be callable by chil… 

    …d types
    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    98e1faf View commit details
    Browse the repository at this point in the history

  17. Activate CA1027: Mark enums with FlagsAttribute

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0f71ac4 View commit details
    Browse the repository at this point in the history

  18. Activate and fix CA1062: Validate arguments of public methods

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    88ad5b4 View commit details
    Browse the repository at this point in the history

  19. Activate CA1063: Implement IDisposable correctly

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ff85a9b View commit details
    Browse the repository at this point in the history

  20. Activate CA1064: Exceptions should be public

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2900fcf View commit details
    Browse the repository at this point in the history

  21. Activate CA1065: Do not raise exceptions in unexpected locations

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2069400 View commit details
    Browse the repository at this point in the history

  22. Activate CA1066: Implement IEquatable when overriding Equals

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    50394d9 View commit details
    Browse the repository at this point in the history

  23. Activate and fix CA1810: Initialize reference type static fields inline

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    221423e View commit details
    Browse the repository at this point in the history

  24. Activate and fix CA1820: Test for empty strings using string length

    @bkoelman
    bkoelman committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    20c9da1 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Activate and fix CA1849: Call async methods when in an async method

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    66fa5b8 View commit details
    Browse the repository at this point in the history

  2. Activate and fix CA2000: Dispose objects before losing scope

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    eaf5e74 View commit details
    Browse the repository at this point in the history

  3. Activate CA2119: Seal methods that satisfy private interfaces

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ae46adf View commit details
    Browse the repository at this point in the history

  4. Activate CA2207: Initialize value type static fields inline

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    3c25632 View commit details
    Browse the repository at this point in the history

  5. Activate CA2217: Do not mark enums with FlagsAttribute

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    102af34 View commit details
    Browse the repository at this point in the history

  6. Order rule IDs

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    fdc9f82 View commit details
    Browse the repository at this point in the history

  7. Fix ASP0015: Suggest using IHeaderDictionary properties

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    435b998 View commit details
    Browse the repository at this point in the history

  8. Fix IDE0079: Remove unnecessary suppression

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b1d11e2 View commit details
    Browse the repository at this point in the history

  9. Optimize RegexOptions

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    e8b7160 View commit details
    Browse the repository at this point in the history

  10. Fix IDE0200: Remove unnecessary lambda expression

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    3730a90 View commit details
    Browse the repository at this point in the history

  11. Fix IDE0210: Convert to top-level statements

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    5bf36a8 View commit details
    Browse the repository at this point in the history

  12. Fix IDE0290: Use primary constructor

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    bc53141 View commit details
    Browse the repository at this point in the history

  13. Fix IDE0041: Use 'is null' check

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    624bcc5 View commit details
    Browse the repository at this point in the history

  14. Fix/suppress IDE0055: Formatting rule 

    Suppressed in various files because the analyzer is buggy, inconsistent and inflexible.
    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    b2e7953 View commit details
    Browse the repository at this point in the history

  15. Fix IDE0280: Use 'nameof'

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d7c06e3 View commit details
    Browse the repository at this point in the history

  16. Fix IDE0078: Use pattern matching

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    68d66d1 View commit details
    Browse the repository at this point in the history

  17. Suppress IDE0019: Use pattern matching to avoid 'as' followed by a 'n… 

    …ull' check

Applying the refactoring changes the order of execution
    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    edcfcbf View commit details
    Browse the repository at this point in the history

  18. Optimize IDE* rules to minimize noise, enable recommended ruleset

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d98fc04 View commit details
    Browse the repository at this point in the history

  19. Turn off various info-level rules from CSharpGuidelinesAnalyzer

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0202a8a View commit details
    Browse the repository at this point in the history

  20. Activate SYSLIB1045: Use GeneratedRegexAttribute to generate the regu… 

    …lar expression implementation at compile time
    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    8af76a1 View commit details
    Browse the repository at this point in the history

  21. Activate and fix CA1508: Avoid dead conditional code

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    84608a8 View commit details
    Browse the repository at this point in the history

  22. Review/update ArgumentGuard usages: 

    - Logger category name can consist of whitespace
- Assembly/type/member name can NOT consist of whitespace
- JSON:API field name can NOT consist of whitespace
    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    2cd4190 View commit details
    Browse the repository at this point in the history

  23. Return better error for whitespace relationship name in request URL

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    37c03ec View commit details
    Browse the repository at this point in the history

  24. Fix incorrect resource inheritance tests

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    2b4ef36 View commit details
    Browse the repository at this point in the history

  25. Use 'is' operator

    @bkoelman
    bkoelman committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    7061e4c View commit details
    Browse the repository at this point in the history

  26. Merge pull request #1609 from json-api-dotnet/code-quality-refresh 

    Code quality refresh
    @bkoelman
    bkoelman authored Sep 21, 2024
    Configuration menu
    Copy the full SHA
    4802639 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Fix one more place where a collection expression can be used

    @bkoelman
    bkoelman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6f3dbd9 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Fix broken SQL Server regexes in Dapper example

    @bkoelman
    bkoelman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9648cde View commit details
    Browse the repository at this point in the history

  2. Update formatting rules to place call to base in primary constructor … 

    …on separate line
    @bkoelman
    bkoelman committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    51d2e49 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1612 from json-api-dotnet/formatter-primary-ctor-… 

    …newline

Update formatting rules to place call to base in primary constructor on separate line
    @bkoelman
    bkoelman authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f8a45c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Package updates (#1614) 

    * Update to Resharper 2024.2.5

* Package updates
    @bkoelman
    bkoelman authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7750d6c View commit details
    Browse the repository at this point in the history

  2. Bump dotnet-reportgenerator-globaltool from 5.3.9 to 5.3.10 (#1613)

    @dependabot
    dependabot[bot] authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b09dc7e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into merge-master-into-openapi

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1756004 View commit details
    Browse the repository at this point in the history

  4. Resharper: fix primary constructor

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    df55a7e View commit details
    Browse the repository at this point in the history

  5. Wrap faker.Generate methods, so that a non-nullable return type is in… 

    …ferred
    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    077a426 View commit details
    Browse the repository at this point in the history

  6. Use source-generated structured logging, fixes rule CA1848: use the L… 

    …oggerMessage delegates
    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7329594 View commit details
    Browse the repository at this point in the history

  7. Replace ToPascalCase extension method with Humanizer call

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5530832 View commit details
    Browse the repository at this point in the history

  8. Fix SYSLIB1045: Use 'GeneratedRegexAttribute' to generate the regular… 

    … expression implementation at compile time
    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0bbaed7 View commit details
    Browse the repository at this point in the history

  9. Fix CA1810: Initialize reference type static fields inline

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fba9efa View commit details
    Browse the repository at this point in the history

  10. Suppress CA1852: Seal internal types

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a5337ac View commit details
    Browse the repository at this point in the history

  11. Fix CA1859: Use concrete types when possible for improved performance

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    af0414f View commit details
    Browse the repository at this point in the history

  12. Replicate changes from master into copied files

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fd5bc84 View commit details
    Browse the repository at this point in the history

  13. Fix CA1062: Validate arguments of public methods

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9597b20 View commit details
    Browse the repository at this point in the history

  14. Suppress CA1064: Exceptions should be public

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dca3ba8 View commit details
    Browse the repository at this point in the history

  15. Suppress CA1711: Identifiers should not have incorrect suffix

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    eb05856 View commit details
    Browse the repository at this point in the history

  16. Fix CA1853: Unnecessary call to 'Dictionary.ContainsKey(key)'

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    150eb26 View commit details
    Browse the repository at this point in the history

  17. Fix CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) method

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ef56e34 View commit details
    Browse the repository at this point in the history

  18. Fix CA1860: Avoid using 'Enumerable.Any()' extension method

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6e32ad5 View commit details
    Browse the repository at this point in the history

  19. Fix CA2016: Forward the CancellationToken parameter to methods that t… 

    …ake one
    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b6c2768 View commit details
    Browse the repository at this point in the history

  20. Fix CA2201: Do not raise reserved exception types

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f45335b View commit details
    Browse the repository at this point in the history

  21. Fix CA5372: Use XmlReader for XPathDocument

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    802dcfc View commit details
    Browse the repository at this point in the history

  22. Fix IDE0200: Remove unnecessary lambda expression

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2f54984 View commit details
    Browse the repository at this point in the history

  23. Fix CA2000: Dispose objects before losing scope

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ee93822 View commit details
    Browse the repository at this point in the history

  24. Fix CA1001: Types that own disposable fields should be disposable

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fb1278a View commit details
    Browse the repository at this point in the history

  25. Package updates

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aa17e02 View commit details
    Browse the repository at this point in the history

  26. Reformat solution

    @bkoelman
    bkoelman committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    abfc8c8 View commit details
    Browse the repository at this point in the history