-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/f 158 linechart component additional functionalities for forecast #116
Feature/f 158 linechart component additional functionalities for forecast #116
Conversation
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we need a consistent way of showing forecast data that is handled by the linechart component. Otherwise we might have a situation where every component is repeating the same code, or every component has different way to show prediction. My suggestion would be to add a flag or type to lines parameter indicating that a line is a forecast or not. And LineChart would apply the styles based on that. By the way I like the styling you applied, especially this one
… reflect predcition styling
@bohdangarchu @marinovl7 - I added the additional params note: the LineChartOperations is becoming quite big and complex -> i will refactor it a bit in F-165 |
038e4b4
to
99bb99c
Compare
…-functionalities-for-forecast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
F-158 Linear
I have now added some functionalities to the LineChart that make it clean and easy to distinguish between forecast and non-forecast data.
On the
/elements
page, I’ve added three proposals for how a chart, including a forecast line, could look like.However, I don’t think it makes sense to explicitly add extra parameters to the LineChart component to handle forecast data.
The components using the LineChart should be responsible for correctly setting the LineChart parameters. For example, the FSC component would be responsible for fetching the data and correctly setting the LineChart component's parameters (eg determining which line is dashed and which is not).